Skip to content

Update create-tidb-instance-premium.md#22730

Open
qqqdan wants to merge 1 commit intorelease-8.5from
min-rcu-change
Open

Update create-tidb-instance-premium.md#22730
qqqdan wants to merge 1 commit intorelease-8.5from
min-rcu-change

Conversation

@qqqdan
Copy link
Copy Markdown
Contributor

@qqqdan qqqdan commented Apr 10, 2026

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 10, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kissmydb for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 10, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for creating TiDB Premium instances, specifically clarifying the calculation and billing of Request Capacity Units (RCUs). The feedback suggests restoring bold formatting for UI elements and key terms like "Capacity" and "Minimum Billing RCU" to maintain consistency, as well as fixing a spacing issue between sentences.

5. In the **Capacity** area, set the maximum number of the Request Capacity Units (RCUs) for your instance.

RCUs represent the compute resources provisioned for your workload. TiDB Cloud automatically scales your instance within this range based on demand.
5. In the Capacity area, set the maximum number of Request Capacity Units (RCUs) for your instance.RCUs represent the compute resources provisioned for your workload. TiDB Cloud automatically scales your instance within this range based on demand.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

There is a missing space between the sentences. Also, Capacity should be bolded to match the styling of other UI elements in this document.

Suggested change
5. In the Capacity area, set the maximum number of Request Capacity Units (RCUs) for your instance.RCUs represent the compute resources provisioned for your workload. TiDB Cloud automatically scales your instance within this range based on demand.
5. In the **Capacity** area, set the maximum number of Request Capacity Units (RCUs) for your instance. RCUs represent the compute resources provisioned for your workload. TiDB Cloud automatically scales your instance within this range based on demand.
References
  1. Correct English grammar, spelling, and punctuation mistakes, if any. (link)

>
> You will be billed for the **Minimum Billing RCU** shown below the maximum number of RCUs, even if your actual usage is lower. The maximum RCU value must be set in increments of 100.
>
> You will be billed for a Minimum Billing RCU, which is 25% (1/4) of your set Maximum RCU (or a minimum of 5,000 RCUs, whichever is higher). This floor ensures that dedicated resources are reserved to guarantee your peak performance. You will be charged this minimum amount even if your actual usage is lower.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Minimum Billing RCU should be bolded to highlight the term and maintain consistency with the previous version of the document.

Suggested change
> You will be billed for a Minimum Billing RCU, which is 25% (1/4) of your set Maximum RCU (or a minimum of 5,000 RCUs, whichever is higher). This floor ensures that dedicated resources are reserved to guarantee your peak performance. You will be charged this minimum amount even if your actual usage is lower.
> You will be billed for a **Minimum Billing RCU**, which is 25% (1/4) of your set Maximum RCU (or a minimum of 5,000 RCUs, whichever is higher). This floor ensures that dedicated resources are reserved to guarantee your peak performance. You will be charged this minimum amount even if your actual usage is lower.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 10, 2026

@qqqdan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify 15b4451 link true /test pull-verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant