Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for creating TiDB Premium instances, specifically clarifying the calculation and billing of Request Capacity Units (RCUs). The feedback suggests restoring bold formatting for UI elements and key terms like "Capacity" and "Minimum Billing RCU" to maintain consistency, as well as fixing a spacing issue between sentences.
| 5. In the **Capacity** area, set the maximum number of the Request Capacity Units (RCUs) for your instance. | ||
|
|
||
| RCUs represent the compute resources provisioned for your workload. TiDB Cloud automatically scales your instance within this range based on demand. | ||
| 5. In the Capacity area, set the maximum number of Request Capacity Units (RCUs) for your instance.RCUs represent the compute resources provisioned for your workload. TiDB Cloud automatically scales your instance within this range based on demand. |
There was a problem hiding this comment.
There is a missing space between the sentences. Also, Capacity should be bolded to match the styling of other UI elements in this document.
| 5. In the Capacity area, set the maximum number of Request Capacity Units (RCUs) for your instance.RCUs represent the compute resources provisioned for your workload. TiDB Cloud automatically scales your instance within this range based on demand. | |
| 5. In the **Capacity** area, set the maximum number of Request Capacity Units (RCUs) for your instance. RCUs represent the compute resources provisioned for your workload. TiDB Cloud automatically scales your instance within this range based on demand. |
References
- Correct English grammar, spelling, and punctuation mistakes, if any. (link)
| > | ||
| > You will be billed for the **Minimum Billing RCU** shown below the maximum number of RCUs, even if your actual usage is lower. The maximum RCU value must be set in increments of 100. | ||
| > | ||
| > You will be billed for a Minimum Billing RCU, which is 25% (1/4) of your set Maximum RCU (or a minimum of 5,000 RCUs, whichever is higher). This floor ensures that dedicated resources are reserved to guarantee your peak performance. You will be charged this minimum amount even if your actual usage is lower. |
There was a problem hiding this comment.
Minimum Billing RCU should be bolded to highlight the term and maintain consistency with the previous version of the document.
| > You will be billed for a Minimum Billing RCU, which is 25% (1/4) of your set Maximum RCU (or a minimum of 5,000 RCUs, whichever is higher). This floor ensures that dedicated resources are reserved to guarantee your peak performance. You will be charged this minimum amount even if your actual usage is lower. | |
| > You will be billed for a **Minimum Billing RCU**, which is 25% (1/4) of your set Maximum RCU (or a minimum of 5,000 RCUs, whichever is higher). This floor ensures that dedicated resources are reserved to guarantee your peak performance. You will be charged this minimum amount even if your actual usage is lower. |
|
@qqqdan: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?